Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove okteto cloud mentions #4343

Closed
wants to merge 1 commit into from
Closed

WIP: remove okteto cloud mentions #4343

wants to merge 1 commit into from

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Jun 14, 2024 •
edited

Proposed changes

Fixes: DEV-472

Removing Okteto Cloud mentions since it has been sunsetted earlier this year.

CLI Quality Reminders 馃敡

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@andreafalzetti andreafalzetti added release/internal 3.0 run-e2e When used on a PR run windows & unix e2e labels Jun 14, 2024
andreafalzetti
andreafalzetti commented Jun 14, 2024
View reviewed changes
pkg/analytics/track.go
@@ -336,8 +336,5 @@ func track(event string, success bool, props map[string]interface{}) {
}

func disabledByOktetoAdmin() bool {
if okteto.IsOktetoCloud() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed because okteto own clusters have and should be disabled using the backend settings

@andreafalzetti andreafalzetti force-pushed the af/remove-okteto-cloud-mention branch 2 times, most recently from 173c3ed to 3ef5f84 Compare June 14, 2024 18:39
@andreafalzetti
remove okteto cloud mentions
ca3ccf3 
Signed-off-by: Andrea Falzetti <[email protected]>
@pchico83
Copy link
Contributor

@andreafalzetti could we send this PR against master? or does it have CLI 3.0 changes?

@andreafalzetti
Copy link
Contributor Author

@andreafalzetti could we send this PR against master? or does it have CLI 3.0 changes?

We could send it to master but I didn't want to add scope to the next release. Did you see any benefit in releasing it sooner?

@andreafalzetti andreafalzetti changed the title remove okteto cloud mentions WIP: remove okteto cloud mentions Jun 15, 2024
@pchico83
Copy link
Contributor

@andreafalzetti could we send this PR against master? or does it have CLI 3.0 changes?

We could send it to master but I didn't want to add scope to the next release. Did you see any benefit in releasing it sooner?

In general, the sooner a change can be released, the better. Not a big deal, but I think it's more important to reduce the scope of CLI 3.0 than the one of the next release

@andreafalzetti
Copy link
Contributor Author

Closed in favour of #4345

@andreafalzetti andreafalzetti deleted the af/remove-okteto-cloud-mention branch June 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.0 release/internal run-e2e When used on a PR run windows & unix e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreafalzetti @pchico83