remove unused code (build) #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Falzetti <[email protected]>
andreafalzetti
added
release/internal
run-e2e
|
@ifbyol did you leave the basic builder |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4311 +/- ##
==========================================
- Coverage 43.22% 43.21% -0.02%
==========================================
Files 371 371
Lines 30027 30003 -24
==========================================
- Hits 12979 12965 -14
+ Misses 15924 15914 -10
Partials 1124 1124 |
I think it was being used in the first refactor but probably usages were removed in other changes. It can be removed |
ifbyol
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unused code:
NewBuilderFromScratchis never calledgetServiceShaInCacheis never called (only in tests)getImageReferencesForTagWithDefaultsis never called (only in tests)