DEV-335 Repository is not being calculated correctly for Smart Builds when the manifest is within a subdirectory of a repository

[ifbyol]

Proposed changes

Fixes DEV-335

When calculating the git repository for Smart Builds we were not checking parent folders to get git metadata and extract the remote URL. This was generating that for example, if you have the following structure:

root/
  |- subdirA/
         |- okteto.yml

And you execute okteto deploy from subdirA, image were being rebuilt every time because we don't extract git metadata correctly.

Also, the filename stored in the configmap wasn't right because we were storing empty or okteto.yml instead of storing the file relative to the root of the repo, so redeploy or destroy from the UI are not working correctly. Currently, we just store the filename if it was specified by the user using -f flag.

In other part of the code, we were calculating the repository checking parent folders, but in a different way, so I modified both places to use the same logic. In this case, we use the property DetectDotGit and pass it to git.PlainOpenWithOptions.

Starting to calculate the git repository generates that the dev environment name inferred might be different, as the git repository has preference over the folder name.

How to validate

Execute deploys and build operations in different scenarios:

• From the root of a repo having the manifest in the root without specifying it with -f (no filename is stored in the configmap)
• From the root of a repo having the manifest in the root specifying it with -f
• From the root of a repo having the manifest in a subfolder specifying it with -f
• From the root of a repo having a compose in the root without specifying it with -f (no filename is stored in the configmap)
• From the root of a repo having a compose in the root specifying it with -f
• From the root of a repo having a compose in a subfolder specifying it with -f
• From a subfolder of a repo having the manifest in the same folder without specifying it with -f (no filename is stored in the configmap)
• From a subfolder of a repo having the manifest in the same folder specifying it with -f
• From a subfolder of a repo having the manifest in a subfolder specifying it with -f
• From a subfolder of a repo having a compose in the same folder without specifying it with -f (no filename is stored in the configmap)
• From a subfolder of a repo having a compose in the same folder specifying it with -f
• From a subfolder of a repo having a compose in a subfolder specifying it with -f
• From a subfolder of a repo having a manifest in the root specifying it with -f
• From a subfolder of a repo having a compose in the root specifying it with -f
• From a folder with no repository having a manifest
• From a folder with no repository having a compose

For all the cases with repositories, make sure that redeploy works fine. Also, check that the filename stored in the configmap is the correct one when using the -f option (otherwise, the filename is not stored)

CLI Quality Reminders 🔧

For both authors and reviewers:

• Scrutinize for potential regressions
• Ensure key automated tests are in place
• Build the CLI and test using the validation steps
• Assess Developer Experience impact (log messages, performances, etc)
• If too broad, consider breaking into smaller PRs
• Adhere to our code style and code review guidelines

[ifbyol]

This (and the rest of changes in this file) is needed because, as the tests run within okteto/okteto repository, it is being detected and added the annotation because it is considered an Okteto sample. I tried to change it, but there is no easy way to do it as it uses current working directory internally

[ifbyol]

This is needed to prevent the test to detect okteto/okteto repository

[codecov]

Codecov Report

Attention: Patch coverage is 31.81818% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 43.05%. Comparing base (19eb936) to head (8ac172b).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4307      +/-   ##
==========================================
- Coverage   43.10%   43.05%   -0.05%     
==========================================
  Files         371      371              
  Lines       30021    30045      +24     
==========================================
- Hits        12940    12936       -4     
- Misses      15954    15975      +21     
- Partials     1127     1134       +7