Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timer): don't print timer when clearing terminal screen #12370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nbelles
Copy link

@Nbelles Nbelles commented Apr 20, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • fix(timer): Add check to see if last command that was run was clear and if so, don’t print the output of the timer.

Other comments:

The current behavior of the timer plugin is that it outputs the result of the timer even when the last command is the clear command. This poses a problem because once the screen has been cleared, it adds one more line to print the timer at the top of the screen before then printing out the terminal prompt. To fix this, I have added a simple check to see if the last command run is the clear command and if so, do not print the result of the timer.

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

1 participant