Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled showing number of git stashes for themes and applied the change to af-magic theme #12264

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jacobmoroni
Copy link

@jacobmoroni jacobmoroni commented Mar 6, 2024

Standards checklist:

  • [ x] The PR title is descriptive.
  • [ x] The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • [ x] The code follows the code style guide detailed in the wiki.
  • [ x] The code is mine or it's from somewhere with an MIT-compatible license.
  • [ x] The code is efficient, to the best of my ability, and does not waste computer resources.
  • [ x] The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • in git.sh I check the stash list and if the theme variables are set, it reports the number of stashed entries in the git status
  • in af-magic.sh I set the necessary variables to enable visualizing the stash
  • if those are not set, this logic is ignored

Other comments:

Clean State (unchanged):
image
Dirty State (unchanged):
image
Dirty Stash state (Dirty and has a stash):
image
Clean Stash state (Clean and has a stash):
image

...

@ohmyzsh ohmyzsh bot added Area: theme Issue or PR related to a theme Area: core Issue or PR related to core parts of the project labels Mar 6, 2024
@jacobmoroni
Copy link
Author

I think it would make sense to keep those lines in af-magic theme commented out or just not in there to not mess up other people using it. It would just be nice to add the option to view this in any theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project Area: theme Issue or PR related to a theme
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

1 participant