Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmux sessiongroup support -- Make ZSH_TMUX_AUTOCONNECT better on multiple concurrent terminals #12032

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kjelderg
Copy link

@kjelderg kjelderg commented Nov 9, 2023

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Added new feature to plugins/tmux when ZSH_TMUX_AUTOCONNECT is enabled. This new feature leverages tmux session groups to improve the experience when using multiple virtual terminals. Each virtual terminal is connected to a separate session in the same session group -- sharing the same windows with other terminals but allowing each session to view a different window.
  • Added a new boolean variable, ZSH_TMUX_SESSIONGROUP (default: true), that selects between the new session group functionality or the previous attach-based functionality.

Other comments:

There was a related ticket (#8680) that was moved to a discussion, but I do not think made it into the project.
I have been testing this for a few months now as my daily driver. It seems vastly preferable when connecting with multiple terminals (I do one terminal on each monitor) than the existing behaviour.
...

Add ZSH_TMUX_SESSIONGROUP variable to documentation.
Add ZSH_TMUX_SESSIONGROUP variable to allow AUTOCONNECT to connect via a sessiongroup.
@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

2 participants