Fix table alias location tracking #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
commented
Mar 25, 2024
| ident_aliased -> (%kw_as ident {% last %}) | ident {% unwrap %} | ||
| ident_aliased -> (%kw_as ident {% last %}) | ident {% last %} |
There was a problem hiding this comment.
suggestions on this? my only reasoning for using last here is because, unlike unwrap, it handles tracking under the hood.
Comment on lines
+1064
to
+1084
| checkSelectLoc('select * from test as t', { | ||
| _location: { start: 0, end: 23 }, | ||
| type: 'select', | ||
| from: [{ | ||
| _location: { start: 14, end: 23 }, | ||
| type: 'table', | ||
| name: { | ||
| _location: { start: 14, end: 23 }, | ||
| name: 'test', | ||
| alias: 't', | ||
| } | ||
| }], | ||
| columns: [{ | ||
| _location: { start: 7, end: 8 }, | ||
| expr: { | ||
| _location: { start: 7, end: 8 }, | ||
| type: 'ref', | ||
| name: '*', | ||
| } | ||
| }] | ||
| }); |
There was a problem hiding this comment.
This test passes on master and on this branch
Comment on lines
+1086
to
+1106
| checkSelectLoc('select * from test t', { | ||
| _location: { start: 0, end: 20 }, | ||
| type: 'select', | ||
| from: [{ | ||
| _location: { start: 14, end: 20 }, | ||
| type: 'table', | ||
| name: { | ||
| _location: { start: 14, end: 20 }, | ||
| name: 'test', | ||
| alias: 't', | ||
| }, | ||
| }], | ||
| columns: [{ | ||
| _location: { start: 7, end: 8 }, | ||
| expr: { | ||
| _location: { start: 7, end: 8 }, | ||
| type: 'ref', | ||
| name: '*', | ||
| }, | ||
| }] | ||
| }); |
There was a problem hiding this comment.
This test fails on master. The end positions there are 18 instead of 20, because the t part is omitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this awesome project!
I spotted a bug with the location tracking where table aliases are not tracked if the
ASkeyword is omitted, for example:ASkeyword.ASkeyword.I have proposed a solution that makes the test pass with a minimal change, but I'm not sure if it's the best approach, as I'm unfamiliar with the codebase, so I would really appreciate suggestions.