feat(ogenreflect): add new runtime information package #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.38% // Head: 74.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 74.38% 74.43% +0.05%
==========================================
Files 176 179 +3
Lines 12734 12791 +57
==========================================
+ Hits 9472 9521 +49
- Misses 2781 2789 +8
Partials 481 481
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tdakkota
force-pushed
the
feat/ogenreflect
branch
8 times, most recently
from
f634bed
to
b5963b1
Compare
tdakkota
force-pushed
the
feat/ogenreflect
branch
14 times, most recently
from
0182d17
to
fbd6eb8
Compare
This is a workaround for `goimports`: it does not treat map lookup as missing package, unlike field lookup of global variable. Otherwise, `goimports` will try to search for the non-existing package and will check every package in GOPATH/module cache. This leads to a very big slowdown. Benchstat: ``` name old time/op new time/op delta Generator/api.github.com-4 13.1s ± 1% 4.7s ± 2% -64.10% (p=0.000 n=13+15) Generator/gotd_bot_api-4 8.63s ± 2% 0.91s ± 3% -89.49% (p=0.000 n=13+15) Generator/tinkoff-4 7.96s ± 3% 0.17s ± 6% -97.90% (p=0.000 n=15+14) Generator/manga-4 7.85s ± 2% 0.05s ± 6% -99.38% (p=0.000 n=14+14) name old alloc/op new alloc/op delta Generator/api.github.com-4 1.95GB ± 0% 1.48GB ± 0% -24.32% (p=0.000 n=15+14) Generator/gotd_bot_api-4 710MB ± 1% 220MB ± 0% -69.07% (p=0.000 n=15+15) Generator/tinkoff-4 537MB ± 2% 41MB ± 3% -92.40% (p=0.000 n=15+15) Generator/manga-4 507MB ± 2% 11MB ± 2% -97.87% (p=0.000 n=15+15) name old allocs/op new allocs/op delta Generator/api.github.com-4 41.1M ± 0% 37.5M ± 0% -8.63% (p=0.000 n=15+13) Generator/gotd_bot_api-4 9.86M ± 0% 6.02M ± 0% -39.01% (p=0.000 n=15+14) Generator/tinkoff-4 5.01M ± 1% 1.15M ± 0% -77.11% (p=0.000 n=15+14) Generator/manga-4 4.17M ± 1% 0.30M ± 0% -92.82% (p=0.000 n=15+15) ```
tdakkota
force-pushed
the
feat/ogenreflect
branch
2 times, most recently
from
b054200
to
c158f72
Compare
tdakkota
force-pushed
the
feat/ogenreflect
branch
from
c158f72
to
dd89e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.