Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): re-use parameter type #1197

Merged
merged 3 commits into from
May 21, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Mar 12, 2024

Fixes #1177.

@tdakkota tdakkota marked this pull request as ready for review May 21, 2024 03:35
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (dfdcdd7) to head (81d99fa).
Report is 1 commits behind head on main.

Files Patch % Lines
gen/gen_parameters.go 65.00% 4 Missing and 3 partials ⚠️
gen/tstorage.go 73.33% 2 Missing and 2 partials ⚠️
gen/genctx.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
- Coverage   73.87%   73.85%   -0.02%     
==========================================
  Files         189      189              
  Lines       12772    12807      +35     
==========================================
+ Hits         9435     9459      +24     
- Misses       2796     2802       +6     
- Partials      541      546       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado merged commit e052e9a into ogen-go:main May 21, 2024
14 checks passed
@tdakkota tdakkota deleted the fix/re-use-parameter-type branch May 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(gen): Generate single type for a parameter definition
2 participants