Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] l10n_sa_edi: allow credit notes without reversed entries #166124

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 20, 2024

Previously, only credit notes created from existing Invoices were allowed to be posted & sent to ZATCA. Now, as long as a credit/debit note has a Customer Reference (ref), the system will allow it to be confirmed and submitted

Description of the issue/feature this PR addresses:
Users are not allowed to confirm/submit Credit Notes if they are not linked to an existing Invoice

Current behavior before PR:
Upon confirmation/posting of a Credit Note, if it is not linked to an existing Invoice or does not have a Customer Reference, the system blocks the confirmation

Desired behavior after PR is merged:
As long as a credit note is linked to an existing Invoice or has a valid Custoemr Reference (ref) the system allows it to be confirmed


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #166102

Previously, only credit notes created from existing Invoices were allowed to be posted & sent to ZATCA. Now, as long as a credit/debit note has a Customer Reference (ref), the system will allow it to be confirmed and submitted

X-original-commit: 185bb9b
@robodoo
Copy link
Contributor

robodoo commented May 20, 2024

Pull request status dashboard.

@fw-bot
Copy link
Contributor Author

fw-bot commented May 20, 2024

This PR targets 16.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 20, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label May 20, 2024
robodoo pushed a commit that referenced this pull request May 21, 2024
Previously, only credit notes created from existing Invoices were allowed to be posted & sent to ZATCA. Now, as long as a credit/debit note has a Customer Reference (ref), the system will allow it to be confirmed and submitted

closes #166124

X-original-commit: 185bb9b
Signed-off-by: Josse Colpaert <[email protected]>
@robodoo robodoo closed this May 21, 2024
@fw-bot fw-bot deleted the 16.0-15.0-l10n-sa-edi-credit-note-fix-lGka-fw branch June 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants