[FIX] web: fix issue with spread operator #166111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team,
kebeclibre and
Iucapad
and removed request for
a team
|
Hello @aab-odoo can you plz review this fix? It targets to correct version with the unit test. |
aab-odoo
reviewed
May 21, 2024
| assert.containsOnce(webClient, ".o_kanban_view"); | ||
|
|
||
| const links = [ | ||
| { label: "test1 <R&D>", url: "#action={action.id}&id={order.id}&model=purchase.order" }, |
There was a problem hiding this comment.
Does this url make sense? I don't think it will be evaluated...
There was a problem hiding this comment.
@aab-odoo Yes you are right url doesn't make sense, but here the goal is to check is multiple URL. i think it's doesn't matter the URL action is correct.
As we have did the same for single url test.
And yes we can pass here dynamic url, but it'll just increse the line of code not very useful here.
| `message test1 <R&D>,test2 <R&D>,test3 <R&D> <R&D>`, | ||
| "the notification should have the correct message" | ||
| ); | ||
| assert.containsOnce(webClient, ".o_kanban_view"); |
There was a problem hiding this comment.
this assertion is not really useful.
Instead, could you assert the links href?
jaha-odoo
force-pushed
the
15.0-web-display_notification-fix-multiple-links-jaha
branch
from
ced8766
to
28933a9
Compare
aab-odoo
reviewed
May 21, 2024
| "the notification should have the correct message" | ||
| ); | ||
| const notificationLinks = notificationElement.querySelector(".o_notification_content"); | ||
| links.forEach((link, index) => { |
There was a problem hiding this comment.
we don't really care about the number of lines in tests. In this case, I definitely prefer 3 assert.strictEqual lines that are easier to read that a forEach (which is also written on 3 lines btw).
There was a problem hiding this comment.
@aab-odoo Yeah, The Changes have been made, Thank you for your suggestion
jaha-odoo
force-pushed
the
15.0-web-display_notification-fix-multiple-links-jaha
branch
from
28933a9
to
7c1665d
Compare
Isuue ===== There was a problem with using the spread operator in this function when links contained multiple URLs. For example, const array = ['a', 'b', 'c']. When we use the spread operator for the first time, the result is 'a', 'b', 'c'. However ,when we try to spread it again, it doesn't work properly, it only shows single link inside notification toast Resolution =========== The implementation was updated to correctly handle multiple URLs by removing the spread operator before links.
aab-odoo
force-pushed
the
15.0-web-display_notification-fix-multiple-links-jaha
branch
from
7c1665d
to
0d68b5d
Compare
robodoo
pushed a commit
that referenced
this pull request
May 22, 2024
Isuue ===== There was a problem with using the spread operator in this function when links contained multiple URLs. For example, const array = ['a', 'b', 'c']. When we use the spread operator for the first time, the result is 'a', 'b', 'c'. However ,when we try to spread it again, it doesn't work properly, it only shows single link inside notification toast Resolution =========== The implementation was updated to correctly handle multiple URLs by removing the spread operator before links. closes #166111 Signed-off-by: Aaron Bohy (aab) <[email protected]>
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 3, 2024
Isuue ===== There was a problem with using the spread operator in this function when links contained multiple URLs. For example, const array = ['a', 'b', 'c']. When we use the spread operator for the first time, the result is 'a', 'b', 'c'. However ,when we try to spread it again, it doesn't work properly, it only shows single link inside notification toast Resolution =========== The implementation was updated to correctly handle multiple URLs by removing the spread operator before links. closes odoo#166111 Signed-off-by: Aaron Bohy (aab) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isuue
There was a problem with using the spread operator in this function when links contained multiple URLs. For example, const array = ['a', 'b', 'c']. When we use the spread operator for the first time, the result is 'a', 'b', 'c'. However ,when we try to spread it again, it doesn't work properly, it only shows single link inside notification toast
Resolution
The implementation was updated to correctly handle multiple URLs by removing the spread operator before links.