[IMP] l10n_sa_edi: update tax exemption reasons #166104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jco-odoo
reviewed
May 20, 2024
| @@ -429,8 +429,11 @@ def _get_tax_unece_codes(self, invoice, tax): | |||
| def _exemption_reason(code, reason): | |||
| return { | |||
| 'tax_category_code': code, | |||
| 'tax_exemption_reason_code': reason, | |||
| 'tax_exemption_reason': exemption_codes[reason].split(reason)[1].lstrip(), | |||
| 'tax_exemption_reason_code': reason or "Not subject to VAT", | |||
There was a problem hiding this comment.
Should not this be VATEX-SA-OOS @mebe-odoo ?
There was a problem hiding this comment.
@jco-odoo absolutely, I updated it
mebe-odoo
force-pushed
the
15.0-l10n-sa-edi-update-vat-exemption-reasons
branch
from
102083d
to
07555c9
Compare
|
@robodoo r+ |
|
@jco-odoo you may want to rebuild or fix this PR as it has failed CI. |
ZATCA updated the VAT exemption reason codes to be provided for 0% taxes. This commit aims to expand the list of existing tax exemption reason codes in odoo to include the new reason: VATEX-SA-OOS
mebe-odoo
force-pushed
the
15.0-l10n-sa-edi-update-vat-exemption-reasons
branch
from
07555c9
to
c486e44
Compare
|
@robodoo r+ |
|
I'm sorry, @mebe-odoo: you can't review+. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 22, 2024
ZATCA updated the VAT exemption reason codes to be provided for 0% taxes. This commit aims to expand the list of existing tax exemption reason codes in odoo to include the new reason: VATEX-SA-OOS closes #166104 Signed-off-by: Josse Colpaert <[email protected]>
This was referenced May 22, 2024
5 similar comments
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 3, 2024
ZATCA updated the VAT exemption reason codes to be provided for 0% taxes. This commit aims to expand the list of existing tax exemption reason codes in odoo to include the new reason: VATEX-SA-OOS closes odoo#166104 Signed-off-by: Josse Colpaert <[email protected]>
|
@mebe-odoo @jco-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZATCA updated the VAT exemption reason codes to be provided for 0% taxes. This commit aims to expand the list of existing tax exemption reason codes in odoo to include the new reason: VATEX-SA-OOS
Description of the issue/feature this PR addresses:
Currently the VAT exemption reasons defined in the l10n_sa_edi module do not include all the reasons listed by ZATCA
Current behavior before PR:
Current VAT exemption reasons do not include reason VATEX-SA-OOS, i.e: "Not subject to VAT"
Desired behavior after PR is merged:
Add VAT exemption reason VATEX-SA-OOS
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr