[FIX] documents: revert erased field input after alert dialog #166103
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal of this commit is to ensure that the confirmation dialog close button is allowed to have a different behaviour than the discard button. Because at present, it performs the same action as the discard button but there might be cases when the dialog does not have a discard button and we still want to handle the dialog close action. To enable this, this commit adds an optional callback for dismiss operation to the dialogData.dismiss that will only be executed when a dialog is closed because of the "x" or the "escape" shortcut. Else, it will execute the callback for cancel operation, if any. Example Use Case: - Go to list view or kanban view. - Select the document to preview in the inspector. - Clear the input value of a required field (here, Name or Workspace), and click out or press 'Enter'. - Close the alert dialog via the "X" button or the "escape" shortcut. Issue: An alert dialog indicating a validation error is shown when a field value is cleared. Yet, on closing the dialog, the unnamed document is saved as is. Instead, the changes should be reverted. Cause: The close(dismiss) operation is never handled in case of alert dialog for invalid selection. Hence, by default, it applies the changes made to the field. Fix: The alert dialog for invalid selection is different from the ones which are simply used to display warnings or alert messages because they do not need to perform any action upon closing dialog. In this case, we want to prevent any invalid changes from being applied. It is achieved by calling the `leaveEditMode` method which discards them and switches the config mode. Hence, we do something similar to what is done on the click of `OK` button, on dismissing the dialog as well. This behvaior is introduced because even if user discards the dialog, any change which is not valid should not be applied. Task: 3799280
khpa-odoo
force-pushed
the
17.0-fix-prevent-saving-unnamed-documents-khpa
branch
from
dc189ff
to
499d765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
An alert dialog indicating a validation error is shown when a field value is cleared. Yet, on closing the dialog or clicking on 'Cancel', the unnamed document is saved as is.
Instead, the changes should be reverted.
Cause:
The close/cancel operation is never handled in case of alert dialog for invalid selection. Hence, by default, it applies the changes made to the field.
Fix:
The alert dialog for invalid selection is different from the ones which are simply used to display warnings or alert messages because they do not need to perform any action.
In this case, we want to prevent any invalid changes from being applied. It is achieved by calling the
leaveEditModemethod which discards them and switches the config mode. Hence, we do something similar to what is done on the click ofOKbutton, for the click of `Cancel/Close`` buttons as well. This behvaior is introduced because even if user discards the dialog, any change which is not valid should not be applied.Task: 3799280