[ADD] point_of_sale: link order invoices with reversed orders #166101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team and
davidmonnom
and removed request for
a team
zepa-odoo
force-pushed
the
master-point_of_sale-add_relation_between_pos_order_with_reverse_entry-zepa
branch
from
b900f1c
to
e40a977
Compare
zepa-odoo
force-pushed
the
master-point_of_sale-add_relation_between_pos_order_with_reverse_entry-zepa
branch
3 times, most recently
from
7f7a563
to
2e7f211
Compare
jco-odoo
reviewed
May 22, 2024
| @@ -10,6 +10,7 @@ class AccountMove(models.Model): | |||
| pos_order_ids = fields.One2many('pos.order', 'account_move') | |||
| pos_payment_ids = fields.One2many('pos.payment', 'account_move_id') | |||
| pos_refunded_invoice_ids = fields.Many2many('account.move', 'refunded_invoices', 'refund_account_move', 'original_account_move') | |||
| reversed_pos_order_id = fields.Many2one('pos.order', string="Reversed POS Order") | |||
There was a problem hiding this comment.
"reversed_pos_order_id" is not entirely clear what it is about.
Maybe with an explanation in help="The pos order that was reverted after closing the session to create an invoice for it. "
Or with a better name, but it quite complicated...
Otherwise, we can continue with this.
There was a problem hiding this comment.
@jco-odoo, I applied the suggested changes.
In this commit: - Added a new field to the Journal Entry to reference the POS order, which is also included in the reversed entry of the POS order. - Enhances traceability between original and reversed POS orders and their associated invoices. Task Id: 3937517
In this Commit: - Updated `_compute_amount` method in AccountMove to invert `amount_total_signed` for journal entries associated with reversed POS orders. - Ensures that the total amount reflects the reversal correctly for better accuracy in financial reporting. Task Id: 3937517
zepa-odoo
force-pushed
the
master-point_of_sale-add_relation_between_pos_order_with_reverse_entry-zepa
branch
from
2e7f211
to
de657c6
Compare
|
@robodoo r+ |
|
@robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
May 24, 2024
In this commit: - Added a new field to the Journal Entry to reference the POS order, which is also included in the reversed entry of the POS order. - Enhances traceability between original and reversed POS orders and their associated invoices. Task Id: 3937517 Part-of: #166101
robodoo
pushed a commit
that referenced
this pull request
May 24, 2024
In this Commit: - Updated `_compute_amount` method in AccountMove to invert `amount_total_signed` for journal entries associated with reversed POS orders. - Ensures that the total amount reflects the reversal correctly for better accuracy in financial reporting. Task Id: 3937517 closes #166101 Signed-off-by: Josse Colpaert <[email protected]>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
In this commit: - Added a new field to the Journal Entry to reference the POS order, which is also included in the reversed entry of the POS order. - Enhances traceability between original and reversed POS orders and their associated invoices. Task Id: 3937517 Part-of: odoo#166101
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
In this Commit: - Updated `_compute_amount` method in AccountMove to invert `amount_total_signed` for journal entries associated with reversed POS orders. - Ensures that the total amount reflects the reversal correctly for better accuracy in financial reporting. Task Id: 3937517 closes odoo#166101 Signed-off-by: Josse Colpaert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Task Id: 3937517