Added an option to do odigos version --cli/--cluster to print only th… #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Jun 26, 2024
Makefile
Outdated
| ORG := keyval | ||
|
|
||
| # Cluster Version | ||
| TAG := $(shell kubectl get configmap $(CONFIGMAP_NAME) -n $(NAMESPACE) -o jsonpath='{.data.ODIGOS_VERSION}') |
There was a problem hiding this comment.
Also possible is TAG ?= $(shell odigos version --short)
Eden has a similar change in the Makefile at: https://github.com/odigos-io/odigos/pull/1250/files
There was a problem hiding this comment.
You are right!
In this PR I also added a flag for cli version and cluster version.
So, I'll use it :)
…e version. Removed the need of adding the TAG in the building commands. Added an option not to use TAG in the locally deploy
yodigos
force-pushed
the
contribution_version
branch
from
f8d1cd1
to
58a888b
Compare
blumamir
reviewed
Jun 26, 2024
yodigos
commented
Jun 27, 2024
| fmt.Printf("%s\n", OdigosVersion) | ||
| } |
There was a problem hiding this comment.
@blumamir I changed it so you can do multiple arguments (cli + cluster).. I'm not sure there is or will be a use case for it. But, usually CLIs allow multiple arguments. So even in the future if we will want to add
RonFed
reviewed
Jun 27, 2024
Co-authored-by: Ron Federman <[email protected]>
blumamir
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e version.
Removed the need of adding the TAG in the building commands.