Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JAVA_OPTS and JAVA_TOOL_OPTIONS to envoverwriter #1133

Merged
merged 13 commits into from
May 26, 2024
Merged

Add JAVA_OPTS and JAVA_TOOL_OPTIONS to envoverwriter #1133

merged 13 commits into from
May 26, 2024
+521 −178

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Apr 21, 2024 •
edited

Resolves #1130

@RonFed RonFed requested a review from a team as a code owner April 21, 2024 08:48
@RonFed
Copy link
Contributor Author

RonFed commented Apr 21, 2024 •
edited

  • Allow to define overwrite value per Sdk (internal map per env var)

@RonFed RonFed marked this pull request as draft April 21, 2024 12:10
@RonFed RonFed marked this pull request as ready for review May 23, 2024 20:49
blumamir
blumamir approved these changes May 26, 2024
View reviewed changes
common/otelsdk.go Outdated Show resolved Hide resolved
cli/cmd/uninstall.go Outdated Show resolved Hide resolved
common/envOverwrite/overwriter.go Outdated Show resolved Hide resolved
common/envOverwrite/overwriter.go Outdated Show resolved Hide resolved
common/envOverwrite/overwriter.go Outdated Show resolved Hide resolved
@RonFed RonFed merged commit f8b3686 into odigos-io:main May 26, 2024
11 checks passed
@RonFed RonFed deleted the add_java_envs_to_envOverwrite branch May 26, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blumamir blumamir blumamir approved these changes

@edeNFed edeNFed edeNFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JAVA_OPTS is overriden during instrumentation
3 participants
@RonFed @edeNFed @blumamir