fix setting Lwt_process env on Windows #967
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env
is an "environment block": a null-terminated block of null-terminated strings. usingcaml_stat_strdup_to_os
on it doesn't work, it only copies the first string.instead, we need to use an explicit length (
caml_string_length(env)
), but there's no public*_to_os
function for this so we have to use the internalcaml_win32_multi_byte_to_wide_char
directly.Fixes #966