[fix] better error message when load insert into a table with no pri… #1972
Conversation
|
farm没过是还是因为test_keybtree这个unit_test不稳定 |
| @@ -41,7 +41,7 @@ class ObDDLErrorMessageTableOperator | |||
| int prepare_user_message_buf(const int64_t len); | |||
| bool operator==(const ObBuildDDLErrorMessage &other) const; | |||
| bool operator!=(const ObBuildDDLErrorMessage &other) const; | |||
| TO_STRING_KV(K_(ret_code), K_(ddl_type), K_(affected_rows), K_(user_message), K_(dba_message)); | |||
| TO_STRING_KV(K_(ret_code), K_(ddl_type), K_(affected_rows), K(ObString(user_message_)), K_(dba_message)); | |||
There was a problem hiding this comment.
用message, ObString(user_message_)吧
| const char *str_error = ob_errpkt_strerror(ret_code_, is_oracle_mode); | ||
| const int64_t buf_size = is_ddl_retry_task ? forward_user_message.length() + 1 : OB_MAX_ERROR_MSG_LEN; | ||
| error_message.ret_code_ = ret_code_; | ||
| if (is_parent_task_) { |
There was a problem hiding this comment.
这个is_parent_task_可能会随着状态变化以及RS切主而丢失掉，最好还是记录子任务的ID，这样查询__all_ddl_error_message表也是比较慢的，它上面没有parent_task_id的索引。
There was a problem hiding this comment.
已修改，写一下修改后的逻辑。
对于走索引的问题，__all_ddl_error_message_这种表的索引列是（object_id， target_object_id），修改后的思路是parent task在发现错误后会尝试通过load_child_task_error函数，按照（object_id, parent_id, ret_code）这三列从__all_ddl_error_message_里捞子任务的出错信息。这是能走索引的。
对于持久化问题，目前parent_task_id在ObTableRedefinitionTask和ObColumnRedfinitionTask这两个task的构造函数中将maybe_parent_task激进地设置为true。所有maybe_parent_task为true的task都会走上面load_child_task_error的流程。故障切主后，新主上重新构造这些Task时，maybe_parent_task依然是true
|
farm没过是因为unittest btree_key本身不稳定 |
Task Description
fix confusing error message in load insert , close #1971
Solution Description
When a parent DDL task failed because of the failure of child tasks, it should load error message reported by child tasks from __all_virtual_ddl_error_message table using a insert query SQL with parent_id and err_code as filter.
Passed Regressions
mysql_test:
tools/deploy/mysql_test/test_suite/table_redefinition/t/duplicate_key_load.test
Upgrade Compatibility
Other Information
Release Note