Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hardware decoding when using blur_edges #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nudin
Copy link

@Nudin Nudin commented Sep 7, 2020

Hardware decoding will most often interfer with the filter, therefore disable
it when enabling of blur_edges and restore the original value when disabling.

If you think it would be better to implement this feature as an opt-in/opt-out
feature let me know.

@occivink
Copy link
Owner

occivink commented Sep 8, 2020

I think it would make sense to make this behavior configurable, and simply just warn and abort by default.
If I remember correctly, filters can also be used with all the *-copy hardware decoders.

@Nudin
Copy link
Author

Nudin commented Oct 7, 2020

If I remember correctly, filters can also be used with all the *-copy hardware decoders.

At least on my system it also doesn't work with the -copy versions.

I made it configurable and documented it in the config file. I mad it enable by default, since if it is set to false the script will likely not work for several users, without any benefit.

@shibotto
Copy link

This would be very nice to have for crop.lua as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants