Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/events rss feed #2437

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ishar19
Copy link

@ishar19 ishar19 commented May 19, 2024

Resolves #2392

Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ishar19, this looks awesome! ✨

Here's some things to consider to make this useful for posting updates to social media, and to be useful in RSS readers:

  • the start date of the event should be included in its title
  • instead of using the summary element to hold the location, I would instead use the content element to render the same information that is listed on the event card. Summary element can be omitted.
  • we cannot use the URL to the actual event as atom:id: "The content of an atom:id element MUST be created in a way that assures uniqueness." (see https://www.rfc-editor.org/rfc/rfc4287#section-4.2.6). Using the slug of the event together with its date should be sufficiently unique.

@ishar19
Copy link
Author

ishar19 commented May 20, 2024

Hey @ishar19, this looks awesome! ✨

Here's some things to consider to make this useful for posting updates to social media, and to be useful in RSS readers:

  • the start date of the event should be included in its title
  • instead of using the summary element to hold the location, I would instead use the content element to render the same information that is listed on the event card. Summary element can be omitted.
  • we cannot use the URL to the actual event as atom:id: "The content of an atom:id element MUST be created in a way that assures uniqueness." (see https://www.rfc-editor.org/rfc/rfc4287#section-4.2.6). Using the slug of the event together with its date should be sufficiently unique.

Hey @sabine thanks for the review and insights and recommended changes, let me make those and get back to this
Thanks!

@ishar19
Copy link
Author

ishar19 commented May 27, 2024

so sorry for delay, i was out for a gateway, will try to wrap this up by 2-3 days

@ishar19 ishar19 requested a review from sabine May 29, 2024 09:17
@ishar19
Copy link
Author

ishar19 commented May 29, 2024

hey @sabine i have updated the format, please take a look. Thanks
image

@cuihtlauac
Copy link
Collaborator

We've just merged a PR #2461 which contains generic RSS feed creation logic that could be used here.

@ishar19
Copy link
Author

ishar19 commented May 29, 2024

We've just merged a PR #2461 which contains generic RSS feed creation logic that could be used here.

just saw it, looks really nice, shall i refactor this to use that logic?

@sabine
Copy link
Collaborator

sabine commented May 31, 2024

Ah yes, that would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish an RSS feed for Events
3 participants