Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more libraries to playground #2194

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikochiko
Copy link

@nikochiko nikochiko commented Mar 14, 2024

I am attempting to add a library to the playground - https://github.com/Sudha247/ocaml-joy - so that I can provide an editor and an SVG rendering side by side (I am doing it with a REPL-toplevel here - https://kaustubh.page/joy.ml/).

I need some help with doing this - I can then document the procedure that works.

I am able to load the cmi and the cma.js, but I get a JavaScript TypeError now when I try to do Joy.init_svg "pane-1"
image

Note: this is the branch of Joy that needs to be pinned for this to work: https://github.com/Sudha247/ocaml-joy/tree/svg

@nikochiko nikochiko marked this pull request as draft March 14, 2024 05:04
@nikochiko nikochiko changed the title Add Joy to toplevel Adding more libraries to playground Mar 14, 2024
@nikochiko
Copy link
Author

Now I think this might be an issue with Js_of_ocaml actually - other methods seem to work.

@nikochiko
Copy link
Author

Perhaps because it is trying to manipulate the DOM from a web worker.

@sabine
Copy link
Collaborator

sabine commented Mar 29, 2024

Hey @nikochiko! Sorry, this got lost under all the Outreachy PRs.

Thanks for taking the time to try this. I remember @gpetiot made an attempt at loading packages into the playground also. It would be great if he can comment on this. Also @jonludlam might have a few pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants