Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix wrong error with string literal in comment #1754

Merged
merged 4 commits into from Apr 30, 2024

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented Apr 24, 2024

This test illustrate issue #1753

Commit f07d346 should fix issue #1753

@voodoos voodoos added this to Planned for backporting in Backport to 500 via automation Apr 24, 2024
@voodoos voodoos changed the title tests: wrong error with string literal in comment Test and fix wrong error with string literal in comment Apr 25, 2024
@voodoos voodoos requested a review from xvw April 25, 2024 13:01
Copy link
Collaborator

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good and well tested !

@voodoos voodoos merged commit 4ede924 into ocaml:master Apr 30, 2024
12 checks passed
Backport to 500 automation moved this from Planned for backporting to Ready for backporting Apr 30, 2024
@voodoos voodoos moved this from Ready for backporting to 5.0-501 in Backport to 500 May 13, 2024
voodoos added a commit to voodoos/merlin that referenced this pull request May 13, 2024
Test and fix wrong error with string literal in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

string litteral with an extension node is wrongly marked as being unterminated
2 participants