Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add tests illustrating issue #1610: locate not jumping correctly with path such as
M(C).t
.There are two things leading to this:
reconstruct_identifer
looks broken on module pathsLongident.parse
to parse which is also broken on module path (and infix operators).This PR improve 2 by using
Parser.parse_longident
. This make locate work when the pathM(C).t
is manually inputted by the user. This also fixes another issue related to infix operators.I will keep that PR as a draft until 1 is also fixes (and thus the issue).