fix: don't take build lock for coq top --no-build
#10547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlepigre could you test this? |
Alizter
approved these changes
May 27, 2024
|
@lzy0505 Could you add a changelog entry? Have a look at doc/changes to see how it is done. Once that is done, we can probably merge. |
Signed-off-by: Zongyuan Liu <[email protected]>
|
@Alizter Done. |
|
Thanks this looks good. @rgrinberg @emillon this is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7671 where
dune coq toptries to take the global build lock even if--no-buildis enabled.The problem was that
Common.Builder.termhadallow_buildsset totrueby default and didn't get updated when--no-buildwas specified. This led to the creation of an RPC server at initialization, which triggers the lock.The fix was to update
allow_buildstofalsewithCommon.Builder.forbid_builds.