Fix partial-match warnings #10489
Open
Fix partial-match warnings #10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
fix-partial-match-warnings
branch
from
a7d6863
to
8089568
Compare
|
Thanks. The warnings looks right, however I think we're not yet ready for this code because we still use opam's library to unpack local archives - but not downloaded ones. You can see how we unpack archives in |
|
I won't have time to work on that. Can anyone else take over? |
Signed-off-by: Kate <[email protected]>
emillon
force-pushed
the
fix-partial-match-warnings
branch
from
8089568
to
26ed176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, dune can now be compiled with
OCAMLPARAM=warn-error=+8,_again.Alternative to #10224
@rgrinberg was that what you were thinking of?