UI: Center preview spacing lines #10643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the spacing lines begin in the middle of the box and then are their width wide towards one direction. This means that the larger they are, the more off-center their middle is. This commit changes them to start at half their width left/top of the center and end half the width to the right/bottom of the center, putting the middle in the center.
gxalpha
added
Bug Fix
|
Can someone verify nothing weird happens here with rotated scene items? Otherwise looks good. |
GeorgesStavracas
approved these changes
May 6, 2024
@Warchamp7 works fine with rotated items: |
Warchamp7
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the spacing lines begin in the middle of the box and then are their width wide towards one direction. This means that the larger they are, the more off-center their middle is.
This commit changes them to start at half their width left/top of the center and end half the width to the right/bottom of the center, putting the middle in the center.
Before/After:
Before/After with the width increased 10x for bigger effect:
Motivation and Context
This bothered me for a long time.
How Has This Been Tested?
macOS 14.4.1
See screenshots above.
Also checked for lines wiggling. It appears to be the same behavior as before.
Types of changes
Checklist: