Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Save default values in obs_data JSON serialisation #10641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

derrod
Copy link
Member

@derrod derrod commented May 4, 2024

Description

Serialise default values when converting obs_data to JSON.

Motivation and Context

Pretty much the same as #8205, if we change defaults we have to write migration code and sometimes try to infer what the default should have been to explicitly set it, if we just save the defaults at the time the user created the config in the first place we don't have to worry about it.

How Has This Been Tested?

Ran OBS, played around, seems to work fine.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added the Enhancement Improvement to existing functionality label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants