Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-aux: Disable DeckLink in the Flatpak #10640

Merged
merged 1 commit into from May 8, 2024

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented May 4, 2024

Description

Disable a feature that might never be available in Flatpak since BlackMagic does not provide a stable link to download it as extra-data.

Motivation and Context

Since the Flatpak became part of the repo, nothing has changed on BlackMagic side.

DeckLink libraries are still not redistributable and without stable download link so even extra-data is not usable.

This makes enabling DeckLink feature in the Flatpak impossible without involving customization on the end-user side which is not how Flatpak is designed for.

How Has This Been Tested?

It builds

Types of changes

  • Flatpak cleanup

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added the Linux Affects Linux label May 4, 2024
Since the Flatpak became part of the repo, nothing has changed on
BlackMagic side.

DeckLink libraries are still not redistributable and without stable
download link so even extra-data is not usable.

This makes enabling DeckLink feature in the Flatpak impossible without
involving customization on the end-user side which is not how Flatpak is
designed for.
@tytan652 tytan652 force-pushed the we_waited_enough_decklink branch from 39d8ae5 to 9e6265b Compare May 8, 2024 21:18
@tytan652 tytan652 added this to the OBS Studio (Next Version) milestone May 8, 2024
@RytoEX RytoEX self-assigned this May 8, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RytoEX RytoEX merged commit 5f1d60b into obsproject:master May 8, 2024
14 checks passed
@tytan652 tytan652 deleted the we_waited_enough_decklink branch May 9, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux Affects Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants