obs-ffmpeg: Fix deadlock on shutting down muxer #10597
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The things that happen to get this deadlock:
shutdown_requested
as falseshutdown_requested
to truedata_mutex
new_data_available_event
data_mutex
data_mutex
new_data_available_event
becausechunk_used < 65536 && !shutting_down
data_mutex
new_data_available_event
with the changes the
new_data_available_event
cannot be send from the main thread between the reading ofshutdown_requested
the getting of thedata_mutex
in the io threadMotivation and Context
Got a memory dump Fenrir from a muxer that was stuck.
the main thread is in
ffmpeg_mux_free
waiting for the io thread to close.the io thread is waiting for
new_data_available_event
How Has This Been Tested?
Muxer still works as expected
Types of changes
Checklist: