Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: obs-crowdin-sync Python Rewrite #10578

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Vainock
Copy link
Contributor

@Vainock Vainock commented Apr 21, 2024

Description

Rewrites the obs-crowdin-sync repository in Python and adds the action to this repository.

Changes that come along with it:

  • Translates the UI/cmake/linux/com.obsproject.Studio.metainfo.xml.in file.
  • Creates a pull request instead of pushing directly: Update Translations and AUTHORS Vainock/obs-studio#3
  • Changes the name of English to English (USA) for en-US.
  • Lowers the requirements for new languages to be added to the UI/data/locale.ini.
  • Host the Language string in a separate Language Name file on Crowdin, remove it here.

Makes the organization/repository secret CROWDIN_SYNC_GITHUB_PAT obsolete.

Motivation and Context

The obs-crowdin-sync repository was too much for what it solves.

This solution is better for integration testing, easier to extend, easier for error analysis in the log because you don't have a huge bundled script and much cleaner to look at.

Pushing directly to the repo is bad, creating a PR is safer and transparent.

How Has This Been Tested?

Locally and Vainock#3. The update-crowdin-locales action was tested in a obs-studio and obs-browser fork.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Vainock Vainock force-pushed the crowdin-sync-python branch 2 times, most recently from 290ebb4 to cf44fa4 Compare April 21, 2024 09:16
@WizardCM WizardCM self-requested a review May 4, 2024 23:09
@tytan652
Copy link
Collaborator

tytan652 commented May 9, 2024

Blocked by #10658, once merged please update your code to only translate UI/cmake/linux/com.obsproject.Studio.metainfo.xml.in and not UI/xdg-data/com.obsproject.Studio.metainfo.xml.in.

The latter is in the deprecated CMake path, the former is the new one.

@Vainock
Copy link
Contributor Author

Vainock commented May 11, 2024

@tytan652 Should it also update UI/cmake/linux/com.obsproject.Studio.desktop instead of UI/xdg-data/com.obsproject.Studio.desktop?

@tytan652
Copy link
Collaborator

tytan652 commented May 11, 2024

Yes

I think the change about going away from xdg-data folder has completely gone unseen. We found out about it recently through metainfo regression in CI.

@Vainock
Copy link
Contributor Author

Vainock commented May 11, 2024

Ready for review.

@Vainock Vainock changed the title CI: Rewrite obs-crowdin-sync in Python & add to repository CI: obs-crowdin-sync Python Rewrite May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants