FSE migration to Gensim >=4 #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 25, 2022 16:43
Related to *2Vec-related classes (Word2Vec, FastText, & Doc2Vec) Changed: 1. size ctr parameter is now consistently vector_size everywhere 2. iter ctr parameter is now consistently epochs everywhere 3. index2word and index2entity attribute is now index_to_key 4. vocab dict became key_to_index for looking up a key's integer index, or get_vecattr() and set_vecattr() for other per-key attributes
Minor fixes
|
This pull request introduces 4 alerts when merging a0702e6 into 672e2c5 - view on LGTM.com new alerts:
|
|
Tests still needs to be migrated, leaving these to the repo developers |
This was referenced Jan 27, 2022
Closed
|
This pull request introduces 2 alerts when merging 219c2ae into 672e2c5 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ebcf9b4 into 672e2c5 - view on LGTM.com new alerts:
|
|
@AleMuzzi merged 4.0.0 support. However, I am also going to look into your TfIDF implementation as well, which looks good to me 👍 |
Very well, glad to know that 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed FSE with Gensim >=4 but I was unable to use it due to API compatibility bugs, as discussed in #40 and #43 .
I successfully performed the migration and tested it with success with a KNN classification task.