Add a cookie-csrf-per-request-limit attribute #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh-tt
commented
Apr 24, 2024
| SameSite string `flag:"cookie-samesite" cfg:"cookie_samesite"` | ||
| CSRFPerRequest bool `flag:"cookie-csrf-per-request" cfg:"cookie_csrf_per_request"` | ||
| CSRFExpire time.Duration `flag:"cookie-csrf-expire" cfg:"cookie_csrf_expire"` | ||
| CSRFPerRequestLimit int `flag:"cookie-csrf-per-request-limit" cfg:"cookie_csrf_per_request_limit"` |
There was a problem hiding this comment.
Is this enough to add the flag to config values?
There was a problem hiding this comment.
And how can i configure a default of say 2^32-1?
| csrf := &csrf{cookieOpts: opts} | ||
| clock := clock.Clock{} | ||
| clock.Set(t) | ||
| csrf := &csrf{cookieOpts: opts, time: clock} |
There was a problem hiding this comment.
This clock.Clock used to be only used for tests I think so I'm not sure what the impact of setting it here is?
Signed-off-by: test <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option for a limit in the number of per-request CSRF cookies oauth2-proxy sets. During the doOAuthStart method we call this method in order to remove the oldest cookies.
Motivation and Context
See #2383
How Has This Been Tested?
Using a unit test, I ran
go test ./pgk/cookiesChecklist: