Fix(csrf): fix possible infinite loop #2607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
suggested changes
Apr 12, 2024
Comment on lines
+85
to
+87
| if err != nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
we still don't have logging levels otherwise i would consider adding a debug log here 🤔
There was a problem hiding this comment.
Yes, I would also like to have a log at this point.
I think we can also add a log here without log levels as this error should not occur so often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the CSRF token is set twice, the user ends up in an infinite loop. This loop can only be exited if the user's cookies are deleted.
Instead of only ever decoding the 1st best cookie, all cookies are now searched to see if a suitable cookie can be found.
Motivation and Context
As an administrator, I don't want my users to end up in my loop, which they can't leave without technical knowledge.
This PR will fix #2606
How Has This Been Tested?
This fix was tested by re-executing the reproducing steps defined in the issue.
Checklist: