Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show login page on broken session cookie #2605

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Primexz
Copy link

@Primexz Primexz commented Apr 10, 2024

Description

In this PR, the behaviour is changed once the cookie is incorrect.
Instead of the error page, the sign-in page is now displayed

Motivation and Context

I have explained the details of the error in the issue #2604.
This PR will fix #2604

How Has This Been Tested?

This fix was tested by re-executing the reproducing steps defined in the issue.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@Primexz Primexz requested a review from a team as a code owner April 10, 2024 12:55
@github-actions github-actions bot added the go label Apr 10, 2024
@github-actions github-actions bot added the docs label Apr 10, 2024
@Primexz Primexz changed the title Fix: Show login page on broken cookie Fix: Show login page on broken session cookie Apr 10, 2024
oauthproxy.go Outdated Show resolved Hide resolved
oauthproxy.go Show resolved Hide resolved
oauthproxy.go Show resolved Hide resolved
@Primexz Primexz requested a review from tuunit April 16, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 500 (Internal Server Error) on invalid cookie
3 participants