Perfect forwarding in DTO_INIT createShared function template #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I found this issue while trying to use move semantics in my custom DTOs move constructors and discovered that the deduced arguments are always passed by copy. My code just wouldn't compile without this change, because the source objects that I'm moving the data from have their copy constructors deleted.
This PR solves this problem, the tests seem to run fine as well.