Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/Prepare for el9 test coverage #946

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danmyway
Copy link
Member

  • modify the main.fmf in plans
  • point packit to the EL9 targets

Jira Issues: RHELC-

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {11: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}, 12: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}, 17: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}, 20: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team.

@danmyway danmyway added the test-coverage-enhancement Significant improvement or enhancement of the test coverage. label Sep 27, 2023
@danmyway
Copy link
Member Author

/packit test --labels el9

@danmyway danmyway changed the base branch from el9-conversions to main September 27, 2023 13:05
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (21a763e) to head (98e9c77).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          53       53           
  Lines        4619     4619           
  Branches      809      809           
=======================================
  Hits         4405     4405           
  Misses        137      137           
  Partials       77       77           
Flag Coverage Δ
centos-linux-7 90.45% <ø> (ø)
centos-linux-8 91.43% <ø> (ø)
centos-linux-9 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danmyway danmyway added the tests-run-sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. label Oct 9, 2023
@has-bot
Copy link
Member

has-bot commented Oct 9, 2023

/packit test --labels sanity


@oamg/conversions-qe please review results and provide ack.

@danmyway
Copy link
Member Author

danmyway commented Oct 9, 2023

/packit test --labels sanity

danmyway added a commit to hosekadam/convert2rhel that referenced this pull request Oct 11, 2023
* address comments
* remove the el9 tests definition in .packit.yaml, which won't work
  anyway, polute the checks overview
* the test definition will be handeled separately in oamg#946

Signed-off-by: Daniel Diblik <[email protected]>
@danmyway
Copy link
Member Author

/packit test --labels sanity, el9

@danmyway
Copy link
Member Author

/packit test --labels el9

@danmyway danmyway force-pushed the tests/el9-conversions branch 2 times, most recently from 95ffc7f to e69dc25 Compare April 24, 2024 07:51
* modify the main.fmf in plans
* point packit to the EL9 targets

Signed-off-by: Daniel Diblik <[email protected]>
@danmyway
Copy link
Member Author

/packit test --labels el9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-coverage-enhancement Significant improvement or enhancement of the test coverage. tests-run-sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants