feat: remove legacy cry light from TrackView #17917
Open
+104
−433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
pollend
commented
May 14, 2024
| @@ -880,7 +880,7 @@ struct IAnimSequence | |||
| eSeqFlags_NoSpeed = BIT(13), //!< Cannot modify sequence speed - TODO: add interface control if required | |||
| // eSeqFlags_CanWarpInFixedTime = BIT(14), //!< @deprecated - Timewarp by scaling a fixed time step - removed July 2017, unused | |||
| eSeqFlags_EarlyMovieUpdate = BIT(15), //!< Turn the 'sys_earlyMovieUpdate' on during the sequence. | |||
| eSeqFlags_LightAnimationSet = BIT(16), //!< A special unique sequence for light animations | |||
| // eSeqFlags_LightAnimationSet = BIT(16), //!< A special unique sequence for light animations | |||
There was a problem hiding this comment.
any historical information about this bitfield?
|
Have you tried to use a 03de light in the track view and animate it ? As maybe some of this old logic, even if unused, still need to be ported over to the new lights rather than being deleted |
you do this through the behavior system. you can animate an entity through the component system so you can animate a light this way. |
byrcolin
added
sig/content
gadams3
approved these changes
May 14, 2024
nick-l-o3de
approved these changes
May 17, 2024
pollend
force-pushed
the
feature/remove-legacy-cry-light-track-animation
branch
from
040f9ab
to
75ed596
Compare
nick-l-o3de
approved these changes
May 22, 2024
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feature/remove-legacy-cry-light-track-animation
branch
from
75ed596
to
6baa6a0
Compare
Signed-off-by: Michael Pollind <[email protected]>
lsemp3d
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I don't think Cry Light is used in the current engine.