feat: migrate GetValue SetValue (GHI-1933) #17909
Open
+102
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
commented
May 11, 2024
| } | ||
| } | ||
|
|
||
| ////////////////////////////////////////////////////////////////////////// | ||
| void CCompoundSplineTrack::SetValue(float time, const Vec4& value, bool bDefault, bool applyMultiplier) |
There was a problem hiding this comment.
would need to test CCompoundSplineTrack and see if missing anything. quaternions between AZ and cry_quat are different. I forget how though?
gadams3
approved these changes
May 13, 2024
byrcolin
added
the
sig/content
nick-l-o3de
approved these changes
May 17, 2024
pollend
force-pushed
the
feat/migrate-rest-GetValue-SetValue-GHI-9133
branch
from
c7e9867
to
686d724
Compare
ref: o3de#9133 Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feat/migrate-rest-GetValue-SetValue-GHI-9133
branch
from
686d724
to
387dfbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I migrated the rest of the Get and set values for the node. wonder if this abstraction could be simplified a bit. All these separate overloaded functions seem kind of cumbersome. some kind of container seems more appropriate though. I was thinking of maybe something with a variant?
How was this PR tested?
ref: #9133