Remove bad check for RPI::Image to return an AssetID. #17748
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lloyd Tullues <[email protected]>
byrcolin
added
the
sig/graphics-audio
gadams3
approved these changes
Apr 17, 2024
lsemp3d
approved these changes
Apr 19, 2024
…terial-image-property-fix
martinwinter-huawei
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where setting a Material's image property will fail, as the value gets erroneously converted to an asset id.
How was this PR tested?
On PC, using a custom shader & material with an image property. Setting the property to a runtime create AttachmentImage now succeeds as expected.