Add tests for author.rs (#700)

[gallottino]

Hi guys!

Oniryu95 and me want to collaborate with you to develop onefetch. We started from this simple issue #700.
In future we wants to do something more consistent for this project.

Let us know!

Signed-off-by: gallottino [email protected]
Co-authored-by: Oniryu95 [email protected]

[spenserblack]

Appreciate your interest in making onefetch a well-tested tool! Here are some notes.

In general, try to split up the tests a bit.

Example for writing tests

fn is_odd(n: u32) -> bool {
    if is_even(n) {
        unimplemented!();
    }
    true
}

// good tests
#[test]
fn test_is_odd_true_on_odd_number() {
    assert!(is_odd(1));
}
#[test]
fn test_is_odd_false_on_even_number() {
    assert!(!is_odd(2));
    // when this fails, the first thing we see is that is_odd
    // doesn't handle even numbers
}

// Not so good
#[test]
fn is_odd_works() {
    assert!(is_odd(1));
    assert!(!is_odd(2));
    // when this fails, the first thing we see is that is_odd
    // doesn't work, but we have to dig into the test results
    // to see what isn't working
}

[spenserblack]

If you're testing title(), you might want to make it 2 tests -- one like test_author_info_singular_title and another like test_author_info_plural_title.

[spenserblack]

Suggested change

	println!("{}", authors_info);
	println!("{}", authors_info_2);

Let's keep these print statements out of the tests.

[spenserblack]

See comments like #827 (comment)

Test that the expected plain text is there with .contains instead of including the color formatting in the expected value.

[o2sh]

BTW, if you do want to check the formatting without losing in readability - by adding a sequence of ANSI escape codes - you could just do:

  assert_eq!(
      authors_info.value(),
      "75% John Doe <[email protected]> 1500"
          .color(DynColors::Rgb(255, 0, 0))
          .to_string()
  );

[spenserblack]

Great idea, thanks for bringing that up!

[spenserblack]

Also use .contains here.

This test would be more readable if you just hardcoded the expected percentage, too. Because you control the factors (author's name, etc.) it's OK, even preferable, to hardcode the expected values.

So just make perc a string or a float without any math and test that {perc}% is contained.

[gallottino]

Followed your suggestion :)

[spenserblack]

The tests are much more readable now, thank you!