Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Support for ATS #523

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Language Support for ATS #523

wants to merge 15 commits into from

Conversation

pykenny
Copy link

@pykenny pykenny commented Oct 27, 2021 •
edited

Purpose

Adding language support and icon art for ATS.

Language support at tokei is still undergoing review, and will provide screenshot once it's available.

Logo Reference

http://www.ats-lang.org/MYDATA/theLogo.png

Preview

view

Related PR/issues:

spenserblack
spenserblack requested changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo looks great!
It looks like you committed a couple of .DS_Store files. Can those be removed?

resources/ats.ascii Outdated Show resolved Hide resolved
src/info/langs/language.rs Outdated Show resolved Hide resolved
jake-87
jake-87 suggested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@jake-87 jake-87 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition to the macro in language.rs should be formatted with a tab, due to rustfmt. As your editor is probably consistant with the .editorconfig, which enforces spaces, copy-paste will probably be needed, as it was with fortranlegacy.

@pykenny
Removing .DS_Store files
86250c0
@pykenny
Removing slogan
3b418fd
@pykenny
Minor style fix
ff67af9 
Details:
 - Using tab indentation in language def file
@pykenny
Copy link
Author

pykenny commented Oct 28, 2021

@spenserblack :

The logo looks great!
It looks like you committed a couple of .DS_Store files. Can those be removed?

Maybe adding .DS_Store to .gitignore? I think they were generated when running make build or make install.

@pykenny
Copy link
Author

pykenny commented Oct 28, 2021 •
edited

@jake-87 :

The addition to the macro in language.rs should be formatted with a tab, due to rustfmt. As your editor is probably consistant with the .editorconfig, which enforces spaces, copy-paste will probably be needed, as it was with fortranlegacy.

Fixed! 😃

@stale
Copy link

stale bot commented Feb 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 18, 2022
@spenserblack
Copy link
Collaborator

I wonder when there will be a new release of tokei. XAMPPRocky/tokei#840 was merged a long time ago.

@stale stale bot removed the wontfix label Feb 18, 2022
@o2sh
Copy link
Owner

o2sh commented Feb 19, 2022 •
edited

Yeah, tokei's last release is more than a year old 😟

@o2sh
Copy link
Owner

o2sh commented May 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added stale and removed stale labels May 22, 2022
@pykenny
Using the new approach to add language settings
5559c9a 
Details:
 - Removes the original ASCII template
 - Adds new settings into languages.yaml
@pykenny pykenny requested a review from o2sh as a code owner December 19, 2022 02:26
@vercel
Copy link

vercel bot commented Dec 19, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vercel 🔄 Building (Inspect) Dec 25, 2022 at 0:27AM (UTC)

spenserblack
spenserblack requested changes Dec 19, 2022
View reviewed changes
languages.yaml Outdated Show resolved Hide resolved
@spenserblack
Fix hex colors in YAML
2b57ed0 
`#` starts a comment.
@spenserblack spenserblack enabled auto-merge (squash) June 20, 2023 21:40
@spenserblack
Copy link
Collaborator

spenserblack commented Sep 1, 2023 •
edited

Wow, I thought I went through all the pending PRs, but I missed this one 😆

@pykenny FYI: #1152

@pykenny pykenny mentioned this pull request Sep 2, 2023
Merged
auto-merge was automatically disabled September 9, 2023 02:15

Head branch was pushed to by a user without write access

@pykenny
Copy link
Author

pykenny commented Sep 9, 2023

@spenserblack Sorry for not noticing conflict with upstream. Try the CI pipeline again?

@spenserblack
Copy link
Collaborator

@pykenny no worries. Although the CI will likely still fail right now since tokei hasn't been released with support for ATS yet. Though hopefully gengo will fix that 😉

Anyway, I don't think you have to worry about this PR. You've done all that we could ask a contributor to do to add a new language. it just depends on us fixing upstream issues.

@spenserblack spenserblack mentioned this pull request Oct 17, 2023
Open
1 task
@spenserblack spenserblack mentioned this pull request Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jake-87 jake-87 jake-87 requested changes

@spenserblack spenserblack spenserblack approved these changes

@o2sh o2sh Awaiting requested review from o2sh o2sh is a code owner

Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pykenny @spenserblack @o2sh @jake-87