Fix signature editor style to use available space #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkahle
force-pushed
the
master
branch
3 times, most recently
from
aa2f3c6
to
6fa0a84
Compare
|
@emorikawa @jstejada can we merge this? |
jstejada
force-pushed
the
master
branch
2 times, most recently
from
ef74afe
to
6d2c2b2
Compare
|
@grinich Any update on this since the 2.0 release? |
|
@benkahle I see that this was never merged in. Since Nylas no longer supports this product, we would love for you to create a PR over at Nylas Mail Lives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Edit raw HTML" mode of the signature composer to grow to available space. It now matches the appearance of the default
contenteditablecomponent for plain text.Fixes #3219
Fixes #2809