Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: IncomingMessage destroyed state #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

http: IncomingMessage destroyed state #6

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 6, 2019

IncomingMessage should implement _destroy() instead of overriding
destroy() in order to behave properly like a stream.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag
http: IncomingMessage destroyed state
c74652f 
IncomingMessage should implement _destroy() instead of overriding
destroy() in order to behave properly like a stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ronag