Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): incremental build generators #5

Draft
wants to merge 117 commits into
base: main
Choose a base branch
from

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Jan 10, 2021

  • Remove auto-generated angular generator and executor.
  • Add generator @nxworker/angular:convert-to-buildable.
  • Add generator @ngworker/angular:use-incremental-build.
  • Add @internal/e2e-util library.
  • Add @internal/test-util library.

@nxworker/angular:convert-to-buildable features:

  • Convert library project
    • Unit tests
    • Integration tests
    • End-to-end tests
    • Implementation
    • Review guard clauses. Don't convert publishable libraries or non-Angular libraries with existing build targets. Look up which executor was used for buildable libraries in Nx 10.
  • Convert workspace (all Angular library projects)
    • Unit tests
    • Integration tests
    • End-to-end tests
    • Implementation

@ngworker/angular:use-incremental-build features:

  • Convert application project
    • Unit tests
    • Integration tests
    • End-to-end tests
    • Implementation
    • Review guard clauses. Don't convert non-Angular applications.
  • Convert application project with dependencies (workspace libraries)
    • Unit tests
    • Integration tests
    • End-to-end tests
    • Implementation
  • Convert workspace (all application projects with dependencies/all Angular application and library projects)
    • Unit tests
    • Integration tests
    • End-to-end tests
    • Implementation

See Setup incremental builds for Angular applications for the configuration that is automated by these generators.

@nx-cloud
Copy link

nx-cloud bot commented Jan 10, 2021

Nx Cloud Report

CI ran the following commands for commit edf9963. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx affected:build --base=origin/main 2/1/2021, 7:13:45 AM
#000000 nx affected:lint --parallel --base=origin/main 2/1/2021, 7:13:45 AM
#000000 nx affected:test --parallel --base=origin/main 2/1/2021, 7:13:43 AM
#000000 nx run-many --target=e2e --all --parallel --skip-nx-cache --skip-nx-cache 2/1/2021, 7:13:48 AM

Sent with 💌 from NxCloud.

@LayZeeDK LayZeeDK added this to In progress in nxworker Jan 10, 2021
Comment on lines 12 to 48
if (project.targets.build) {
console.warn(
`Project with name "${projectName} already has a "build" target. Overwriting..."`
);
}
Copy link
Member Author

@LayZeeDK LayZeeDK Jan 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a --force option to override existing targets and otherwise log them, but leave them as is.

@LayZeeDK LayZeeDK force-pushed the angular/feat/incremental-build-generators branch from 80f2d13 to 5f256c7 Compare January 11, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
nxworker
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant