Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .nvmrc more versatile/modular #3235

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

victormihalache
Copy link

Made because of #3234.

As of opening this PR the only difference is that a new --config= flag can be used to indicate the path to the .nvmrc (or any other name for that matter) to be used specifically. It is available to all commands that utilize the .nvmrc file to begin with, those being: install, use, exec, run, which. I have tested all of them using the docker container provided.

What I want to add next are the following features:

  • Look for an .nvmrc file if the path is to a folder, rather than a file.
  • Add more places to look for a config file, besides the .nvmrc in the root.

I would also love to hear the thoughts of @ljharb and other maintainers, but also general users of nvm!

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was premature pending discussion on the issue; I don't value "less config files in the root", and thus the added complexity to nvm is unlikely to be worth it to me (the only maintainer). Let's continue discussion on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants