Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .*rc file for all shells #2511

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

RCMainak
Copy link

Solves issue #2508

Solved the issue with not updating the .*rc file when not installed with BASH. I have tested this with ZSH on Ubuntu.

Note: this fix still requires user to close current terminal & reopen another one.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely will not work as-is - it would require:

  1. Rewriting the install script to work on non-bash shells
  2. Testing the install script on every supported shell

The install script should only ever be run in bash.

@RCMainak
Copy link
Author

I understand what you mean. It worked for me so I thought about sharing. 😅 Works on my machine kind of scenario. Sorry for wasting your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants