fix: add true as accepted value for headings.anchorLinks option
#208
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdehaven
reviewed
May 25, 2024
| @@ -67,7 +67,7 @@ export interface ModuleOptions { | |||
| headings?: { | |||
| anchorLinks?: { | |||
| [heading in 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6']?: boolean | |||
| } | false | |||
| } | boolean | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply add
trueas an accepted value forheadings.anchorLinksoption.This PR is complementary to #206 and if accepted it will close #203.
I tested this both with
pnpm testand manually in the playground, everything seems to be working as expected, but please take a moment to check if the implementation is ok for you.