Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom converters with save #12833

Merged
merged 3 commits into from May 12, 2024
Merged

Fix custom converters with save #12833

merged 3 commits into from May 12, 2024

Conversation

IanManske
Copy link
Member

Description

Fixes #10429 where save fails if a custom command is used as the file format converter.

Tests + Formatting

Added a test.

@IanManske IanManske added the pr:bugfix This PR fixes some bug label May 11, 2024
@IanManske IanManske changed the title Fix custom converter save Fix custom converters with save May 11, 2024
sholderbach
sholderbach approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving this and adding a test.

Makes me think that we are kind of haphazardly using the Command trait for custom commands.

@sholderbach sholderbach merged commit 30fc832 into nushell:main May 12, 2024
15 checks passed
@amtoine
Copy link
Member

amtoine commented May 12, 2024

thanks a lot @IanManske 🙏

@hustcer hustcer added this to the v0.94.0 milestone May 13, 2024
FilipAndersson245 pushed a commit to FilipAndersson245/nushell that referenced this pull request May 18, 2024
@IanManske @FilipAndersson245
Fix custom converters with save (nushell#12833)
332513a 
# Description
Fixes nushell#10429 where `save` fails if a custom command is used as the file
format converter.

# Tests + Formatting
Added a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sholderbach sholderbach sholderbach approved these changes

Assignees
No one assigned
Labels
pr:bugfix This PR fixes some bug
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.

save fails with custom to ndjson command
4 participants
@IanManske @amtoine @sholderbach @hustcer