Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on minimal versions #12765

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

szepeviktor
Copy link
Contributor

Description

From the problem in #12762

@szepeviktor
Copy link
Contributor Author

szepeviktor commented May 4, 2024

Is this a real problem?

error: failed to select a version for `chrono`.
    ... required by package `nu-cli v0.93.1 (/home/runner/work/nushell/nushell/crates/nu-cli)`
versions that meet the requirements `^0.4` are: 0.4.0

the package `nu-cli` depends on `chrono`, with features: `std` but `chrono` does not have these features.

failed to select a version for `chrono` which could resolve this conflict

@sholderbach
Copy link
Member

Thanks for working on this, this seems like a good sanity check, not sure if we should do this on cargo test (makes sense in the specific context of #12762) or also on cargo build as this is closer to a likely place of failure (when using nu crates as libraries) and the added requirements of the dev-dependencies may raise the version requirements as a side effect.

@szepeviktor
Copy link
Contributor Author

Please guide me what to do next.

@sholderbach
Copy link
Member

Please guide me what to do next.

I probably have to think about it a bit more to really have good advice on how we need to set up all the different jobs:

  • We want to test both the versions (and the toolchain)
    • which we are shipping in production
    • and the most minimal version we have specified
  • and for those that only use a crate from our workspace like nu-plugin we need to run this with just cargo build -p <name of crate> to ensure that cargo doesn't resolve the rest (seems like a job for cargo hack?)

In the mean time can you rebase this branch onto main after chrono has been fixed, so we can work on any other remaining failures that become obvious (as it already stopped on feature resolution)?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented May 4, 2024

In the mean time can you rebase this branch onto main

Done 🍏

error: failed to select a version for `uuid`.
    ... required by package `nu_plugin_polars v0.93.1 (/home/runner/work/nushell/nushell/crates/nu_plugin_polars)`
versions that meet the requirements `^1.7` are: 1.7.0

all possible versions conflict with previously selected packages.

  previously selected package `uuid v1.8.0`
    ... which satisfies dependency `uuid = "^1.8.0"` of package `nu-cli v0.93.1 (/home/runner/work/nushell/nushell/crates/nu-cli)`
    ... which satisfies path dependency `nu-cli` of package `nu-lsp v0.93.1 (/home/runner/work/nushell/nushell/crates/nu-lsp)`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants