[Samuel Pang Shao Herng] ip #517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlimyy
reviewed
Sep 1, 2022
src/main/java/Deadline.java
Outdated
| @@ -0,0 +1,14 @@ | |||
| public class Deadline extends Task { | |||
|
|
|||
| protected String by; | |||
There was a problem hiding this comment.
This variable is only used within the class so it could use the private access modifier instead
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| public String addTaskMessage(String taskString) { | ||
| return horizontalBorder + "Got it. I've added this task:\n" + taskString + "\n" + "Now you have " + this.tasklist.getCount() + " tasks in the list.\n" + horizontalBorder; |
There was a problem hiding this comment.
Line length for this line is pretty long so you could look into using line wrapping such as splitting at the addition operators.
src/main/java/Duke.java
Outdated
| System.out.println(welcomeMessage()); | ||
| Scanner scan = new Scanner(System.in); | ||
| String s = scan.nextLine(); | ||
| boolean exitNow = false; |
There was a problem hiding this comment.
You could consider using a variable name which sounds more like a Boolean such as isExit.
src/main/java/Duke.java
Outdated
| try { | ||
| String[] commandList = s.strip().split(" "); | ||
| String command = commandList[0].toLowerCase(); | ||
| if (command.equals("bye") && commandList.length == 1) { |
There was a problem hiding this comment.
You can consider using switch statements here.
src/main/java/Duke.java
Outdated
|
|
||
| private Tasklist tasklist; | ||
|
|
||
| private Duke(){ |
There was a problem hiding this comment.
It does not appear that this constructor is invoked so you could look into omitting this constructor.
Added Gradle support.
Added DeadlineTest and ParserTest classes to conduct testing on the methods of Deadline.java and Parser.java respectively
Added Javadocs for classes in the duke.command package, duke.task package, duke.ui package
Modified the files to ensure switch case statements now have no indentation and Java's conventions with regards to wrapping, newline, whitespace are adhered to.
Added the find feature which allows user to find matching tasks using a keyword
Updated duke with GUI using JavaFX
Assertion statements are able to complement exception handling in handling errors. It is especially useful in indicating mistakes in the code returned Let's, * Write some assertion statements across multiple files to verify the correctness of our code
Certain repetitive tasks existed in the code base, and thus it should abstracted into a method for improvements in code quality and readability. Let's, * Abstract out certain repetitive methods in Storage.java to improve readability and shorten method length * Declare some variables in order to help improve readability and reader understanding
Add assertion statements
There was a merge conflict encountered when trying to merge master and branch-A-Assertions. Lets, - Resolve the merge conflict so that any discrepancies can be successfully resolved
There was a merge conflict encountered when trying to merge master and branch-A-CodeQuality. Lets, * Resolve the merge conflict so that any discrepancies can be successfully resolved
Prior to implementation of extension, users may not have much idea on how to use Duke properly. Let's, * Implement a help feature so that users can view all the commands once after they input "help" in the text field * Implement a advanced help feature so that users can view advanced commands to better utilise Duke
There exists a help and an advanced help message to guide the user on what commands can be utilised. This means that the invalid user input message which guides the user on Duke commands is not necessary. Let's, * change the content in the invalid user input message to be more meaningful and more concise, providing a shorter and more readable instruction for the user
Duke application lacks a user guide to guide the user how to use Duke. Let's, * Create a user guide to give brief instructions to the user to utilise Duke
Some comments were added to indicate some appropriation of code from multiple sources.
Ammended some formatting errors from README.md
Rectified spelling errors of README.md
Proper line spacing was implemented to further categorise portions of the README.md
Some errors in line spacing occured, thus README.md was modified to resolve such errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke
DukePro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
Features
:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: